fix: Fix Managed e2e navigation test flake on SSH tab #9036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdamore-linode
added
e2e
Passing run #3081 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
bnussman-akamai
approved these changes
Apr 20, 2023
cpathipa
approved these changes
Apr 21, 2023
cpathipa
added
Approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Fixes test flake that occurs in
managed-navigation.spec.tswhen both "Unauthorized" notices on the SSH tab load and appear at the same time; Cypress expected only one instance of the notice to appear and would fail when both appeared at the same time.How to test 🧪
Run
yarn && yarn build && yarn start:manager:ciand then:yarn cy:run -s "cypress/e2e/managed/managed-navigation.spec.ts"Confirm that each test passes, preferably on the first attempt.